By all means remove the shingles. Vinyl siding will follow the bumps in the wall and those shingles will cause lots of waves. The sheathing should be smooth and provide a nice surface to attach the vinyl. I would not even talk to an applicator who didn't want to remove the shingles. Removal should not be a major expense, they can peel them off very quickly.