Need help with air hammer/knock.

I am getting a knock when I shut off the faucet, shower valve, or when the toilet stops. Even when using an adjoining bathroom. When replacing the plumbing during the renovation my plumber (brother who lives in FL, I live in IL), installed 2 air chambers on the supply lines for the vanity. We both thought that this would handle the system adequately. I have since strapped all of the supply lines in the house, but it hasn't stopped the knock. It is definitely in the hot water line. Any guesses on how I can eliminate the problem? After spending so much time and effort with beautiful visual results, this knock, clang, bang is driving me nuts!

Thanks,
Kitch

First off, plain air chambers made of pipe will have air in them for a short while until the air is absorbed by the water. After that time, all you end up with is a tube filled with water unless you drain the system every month to refill the air in the chamber. IMO any "'plumber" who installed an air chamber needs to get educated right away. I fear what other lapses may have resulted.

Without going into a complete course on how to plumb copper water lines to avoid piping noise. One thing to do now is:
1. Purchase and install water hammer arrestors like the ones made by Sioux Chief. You could start with a pair under the lav. IF you used 5/8" compression angle stops then you can use the type which come with compression nuts with a built in tee and act like an extension.